refactor: Don't enter streaming engine for groupby-> agg mean/median … (

pola-rs#16810)
Wouittone · Jun 22, 2024 · 67e0af3 · 67e0af3
1 parent 7307448
commit 67e0af3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/crates/polars-pipe/src/executors/sinks/group_by/aggregates/convert.rs b/crates/polars-pipe/src/executors/sinks/group_by/aggregates/convert.rs
@@ -101,7 +101,12 @@ pub fn can_convert_to_hash_agg(
                     }
                 ) && {
                     if let Ok(field) = ae.to_field(input_schema, Context::Default, expr_arena) {
-                        field.dtype.to_physical().is_numeric()
+                        match field.dtype {
+                            DataType::Date => {
+                                matches!(agg_fn, IRAggExpr::Mean(_) | IRAggExpr::Median(_))
+                            },
+                            _ => field.dtype.to_physical().is_numeric(),
+                        }
                     } else {
                         false
                     }

diff --git a/py-polars/tests/unit/streaming/test_streaming_group_by.py b/py-polars/tests/unit/streaming/test_streaming_group_by.py
@@ -103,7 +103,7 @@ def test_streaming_group_by_types() -> None:
             "bool_last": [False],
             "bool_mean": [0.5],
             "bool_sum": [1],
-            "date_sum": [date(2074, 1, 1)],
+            "date_sum": [None],
             # Date streaming mean/median has been temporarily disabled
             # "date_mean": [date(2022, 1, 1)],
             "date_first": [date(2022, 1, 1)],