Skip to content

Commit

Permalink
Fix success messages going to output instead of GitHub summary
Browse files Browse the repository at this point in the history
  • Loading branch information
Alexander01998 committed Dec 23, 2024
1 parent a426e42 commit c2b702c
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions scripts/check_translations.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def check_extra_keys(en_us: dict, translations: dict):
util.add_github_summary(f"- {key}")
if extra_keys_found:
raise Exception("Found extra keys in one or more translation files, see summary")
print("✅ No extra keys found")
util.add_github_summary("✅ No extra keys found")


def check_untranslated_strings(en_us: dict, translations: dict):
Expand Down Expand Up @@ -64,7 +64,7 @@ def check_untranslated_strings(en_us: dict, translations: dict):

if untranslated_strings_found:
raise Exception("Found untranslated strings in one or more translation files, see summary")
print("✅ No accidentally untranslated strings found")
util.add_github_summary("✅ No accidentally untranslated strings found")


def check_order_of_strings(en_us: dict, translations: dict):
Expand All @@ -74,7 +74,7 @@ def check_order_of_strings(en_us: dict, translations: dict):
translation_keys_present_in_en_us = [key for key in data.keys() if key in en_us.keys()]
if en_us_keys_present_in_translation != translation_keys_present_in_en_us:
raise Exception(f"⚠ The order of strings in {lang}.json is different from en_us.json")
print("✅ The order of strings in each translation file matches en_us.json")
util.add_github_summary("✅ The order of strings in each translation file matches en_us.json")


def main():
Expand Down

0 comments on commit c2b702c

Please sign in to comment.