Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Korean Description #872

Closed
wants to merge 12 commits into from
Closed

Add Korean Description #872

wants to merge 12 commits into from

Conversation

JAXPLE
Copy link
Contributor

@JAXPLE JAXPLE commented Aug 18, 2023

Description

  • I translated everything.
  • If there is a problem, I will attach a discord.
  • Discord - JAXPLE#7623
    (Optional) screenshots / videos

I just uploaded the translated version because there is no image reference in other cases.

@JAXPLE
Copy link
Contributor Author

JAXPLE commented Aug 18, 2023

@Alexander01998
The requested part has been modified.

@JAXPLE JAXPLE changed the title Add Korean Translation Add Korean Description Aug 25, 2023
@JAXPLE
Copy link
Contributor Author

JAXPLE commented Aug 28, 2023

@Alexander01998 I'm sorry I didn't finish it perfectly.
Thanks for the help.

Copy link
Member

@Alexander01998 Alexander01998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @JAXPLE,

Thanks a lot for your patience and your work on these translations! 👍

I was able to take care of a few issues, but I've also left some comments on other lines that I would like you to take a look at. If you could sort out these remaining issues, we should be all set.

Cheers
-Alexander01998

"description.wurst.setting.autoeat.injury_threshold": "작은 부상으로 인해 모든 음식이 낭비되는 것을 방지합니다. AutoEat은 최소한 이만큼의 체력을 잃었을 때만 부상 상태로 간주합니다.",
"description.wurst.setting.autoeat.take_items_from": "AutoEat가 음식을 찾을 위치.",
"description.wurst.setting.autoeat.eat_while_walking": "걷는 동안 음식을 먹는 것은 속도를 늦춥니다. 권장하지 않습니다.",
"description.wurst.setting.autoeat.allow_hunger": "김치는 무해한 '배고픔' 효과를 적용시킵니다.\n위급한 상황에서 사용 가능하고 유용합니다.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible inconsistencies:

  • Minecraft translates "Rotten flesh" (item.minecraft.rotten_flesh) as "썩은 살점", but this translation says "김치" instead.
  • Minecraft translates "hunger" (effect.minecraft.hunger) as "허기", but this translation says "배고픔" instead.

Comment on lines 44 to 45
"description.wurst.hack.autosword": "자동으로 인벤토리에서 가장 좋은 무기를 사용하여 Entity를 공격합니다.\n팁: Killaura와 함께 사용할 수 있습니다.",
"description.wurst.hack.autotool": "블록을 부수려고 할 때 인벤토리에서 가장 빠른 적용 가능한 도구를 자동으로 장착합니다.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two translations seem to say "inventory" ("인벤토리"), but both of the hacks can only use items in the player's hotbar. Could you please correct it to use the appropriate term for "hotbar" in Korean? (Minecraft translates "hotbar" as "단축 바" in options.attack.hotbar.)

{
"description.wurst.hack.aimassist": "주변 엔티티를 조준하는 데 도움을 줍니다.",
"description.wurst.hack.airplace": "공중에 블록을 배치할 수 있게 해줍니다.",
"description.wurst.hack.anchoraura": "자동으로 리스폰 앵커를 배치(선택 사항), 충전하고 주변 엔티티를 제거합니다.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible inconsistency: Minecraft translates "respawn anchor" (block.minecraft.respawn_anchor) as "리스폰 정박기", but this translation says "리스폰 앵커" instead.

"description.wurst.hack.anticactus": "선인장 대미지를 방지합니다.",
"description.wurst.hack.antientitypush": "다른 플레이어나 몹에게 밀려나는 것을 방지합니다.",
"description.wurst.hack.antihunger": "걷는 동안 배고픔 속도를 늦춥니다.",
"description.wurst.hack.antiknockback": "플레이어나 몹으로부터 넉백을 받지 않도록 합니다.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible inconsistency: Minecraft translates "knockback" (enchantment.minecraft.knockback) as "밀치기", but this translation says "넉백" instead.

"description.wurst.hack.potionsaver": "정지 상태에서는 모든 물약 효과를 유지합니다.",
"description.wurst.hack.prophuntesp": "Prophunt에서 가짜 블록을 볼 수 있게 해줍니다.\nMineplex Prophunt를 위해 제작되었으며, 다른 서버에서 작동하지 않을 수 있습니다.",
"description.wurst.hack.protect": "가장 가까운 개체를 따라가고 다른 개체로부터 보호하는 봇입니다.\n가장 가까운 개체 대신 특정 개체를 보호하려면 .protect 명령을 사용하세요.",
"description.wurst.hack.radar": "주변 개체의 위치를 보여줍니다.\n§cred§r - 플레이어\n§6orange§r - 몬스터\n§agreen§r - 동물\n§7gray§r - 기타",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The colors "red", "orange", "green", and "gray" are still in English. Please translate them to Korean.

"description.wurst.hack.prophuntesp": "Prophunt에서 가짜 블록을 볼 수 있게 해줍니다.\nMineplex Prophunt를 위해 제작되었으며, 다른 서버에서 작동하지 않을 수 있습니다.",
"description.wurst.hack.protect": "가장 가까운 개체를 따라가고 다른 개체로부터 보호하는 봇입니다.\n가장 가까운 개체 대신 특정 개체를 보호하려면 .protect 명령을 사용하세요.",
"description.wurst.hack.radar": "주변 개체의 위치를 보여줍니다.\n§cred§r - 플레이어\n§6orange§r - 몬스터\n§agreen§r - 동물\n§7gray§r - 기타",
"description.wurst.hack.rainbowui": "§cM§aa§9k§ce§as §9e§cv§ae§9r§cy§at§9h§ci§an§9g §cc§ao§9l§co§ar§9f§cu§al§9.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This string is still in English. Please either translate it to Korean or remove it from the file.
(By the way, this string says "Makes everything colorful.", with alternating §c (red), §a (green), and §9 (blue) color codes on each letter.)

"description.wurst.hack.rainbowui": "§cM§aa§9k§ce§as §9e§cv§ae§9r§cy§at§9h§ci§an§9g §cc§ao§9l§co§ar§9f§cu§al§9.",
"description.wurst.hack.reach": "더 멀리 뻗을 수 있게 해줍니다.",
"description.wurst.hack.remoteview": "다른 사람으로서 세계를 볼 수 있게 해줍니다.\n.rv 명령을 사용하여 특정 개체를 대상으로 설정할 수 있습니다.",
"description.wurst.hack.restock": "인벤토리에서 선택한 아이템으로 손을 자동으로 보충합니다. FastPlace와 함께 사용할 수 있습니다.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible inconsistency: Minecraft translates "inventory" (container.inventory) as "보관함", but this translation says "인벤토리" instead.

"description.wurst.hack.servercrasher": "1.15.x 버전 서버를 충돌시킬 수 있는 아이템을 생성합니다.\n§o크리에이티브 모드 전용.§r",
"description.wurst.hack.skinderp": "스킨의 일부를 무작위로 전환합니다.",
"description.wurst.hack.sneak": "자동으로 웅크리게 합니다.",
"description.wurst.hack.snowshoe": "파우더 눈 위에서 걸을 수 있게 해줍니다.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible inconsistency: Minecraft translates "powder snow" (block.minecraft.powder_snow) as "가루눈", but this translation says "파우더 눈" instead.

"description.wurst.hack.speednuker": "NoCheat+를 우회할 수 없는 더 빠른 버전의 Nuker입니다.",
"description.wurst.hack.spider": "거미처럼 벽을 타고 올라갈 수 있게 해줍니다.",
"description.wurst.hack.step": "전체 블록을 올라갈 수 있게 해줍니다.",
"description.wurst.hack.throw": "아이템을 여러 번 사용합니다. 매우 많은 양으로 눈덩이와 달걀을 던지거나 몹을 소환하고 마인카트를 놓는 등의 작업에 사용할 수 있습니다.\n\n이로 인해 많은 랙이 발생하거나 서버가 충돌할 수 있습니다.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible inconsistency: Minecraft translates "minecart" (entity.minecraft.minecart) as "광산 수레", but this translation says "마인카트" instead.

@JAXPLE
Copy link
Contributor Author

JAXPLE commented Sep 19, 2023

@Alexander01998
I checked my translation file based on the en_us.json file.

All translations are believed to have been completed, and the verification code is attached to the Notion link below, and I think it will be useful when using GPT or Google Translator.

Check for missing key values and sequence.

notion

@Alexander01998 Alexander01998 removed this from the v7.38 milestone Oct 19, 2023
@Alexander01998
Copy link
Member

Hi @JAXPLE,

Thanks for the update! However, after reviewing your revised translation, it appears that most of the issues I had highlighted previously haven't actually been addressed yet. A number of strings which had severe issues - some words still in English, appear to be unchanged from the initial draft.

Could you please revisit my review comments and make the necessary fixes? Alternatively, since this pull request has been open for two months now, perhaps we should just merge the correctly translated strings and leave the ones with issues for a future PR?

Let me know how you'd like to proceed or if you have any questions.


Machine translation:

안녕하세요 @JAXPLE,

업데이트해 주셔서 감사합니다! 하지만 수정된 번역을 검토한 결과, 제가 이전에 강조했던 대부분의 문제가 아직 해결되지 않은 것으로 보입니다. 심각한 문제가 있었던 여러 문자열(일부 단어는 여전히 영어로 되어 있음)이 초기 초안에서 변경되지 않은 것으로 보입니다.

제 검토 의견을 다시 살펴보고 필요한 수정을 해주시겠어요? 아니면 이 풀 리퀘스트가 두 달 동안 열려 있었으므로 올바르게 번역된 문자열은 병합하고 문제가 있는 문자열은 향후 PR을 위해 남겨두는 것이 어떨까요?

어떻게 진행하고 싶은지 또는 궁금한 점이 있으면 알려주세요.

@JAXPLE
Copy link
Contributor Author

JAXPLE commented Oct 19, 2023

@Alexander01998
I left it in English because it fits better in context.
You don't have to worry about this part.
If there is a problem, I will pr again.

Don't forget to add my name to the translation contributor!

@Alexander01998
Copy link
Member

Hi @JAXPLE,

I appreciate your time and effort in working on this translation. However, after taking a closer look at the revised version, I'm afraid that we still have too many issues that need attention, and it appears that the latest changes have actually made some strings less accurate than they were in the first draft. Therefore, I've decided that it would be better not to merge this pull request at the moment.

Please understand that the goal here is to provide the best possible user experience for our Korean users. I appreciate your keen interest in adding your name to the contributors list, but the primary aim should be to provide an accurate and high-quality translation. Rest assured that if a translation is merged, the translator will be acknowledged accordingly in the credits.

I'm closing this pull request for now. I hope you understand my decision. Should you decide to redo the translations and resubmit in the future, please don't hesitate to do so.

Thank you for your understanding and time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants