Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peaks and events #285

Merged
merged 39 commits into from
Dec 7, 2023
Merged

Peaks and events #285

merged 39 commits into from
Dec 7, 2023

Conversation

cfuselli
Copy link
Member

@cfuselli cfuselli commented Nov 1, 2023

Together with Tobias, we did some work on peaks and events plugins.

With this PR we now have:

Peak processing

  • Restructured plugins
  • Fixed area fraction top calculation
  • Peak classification works well, moved to peak_basics (to tune with options)
  • Introduced gain correction (to tune with options, for now)
  • Introduced position reconstruction with center of gravity

Events processing

  • Restructured plugins
  • Added simple S2 area correction for electron lifetime (to tune with options, for now)
  • Added positions at event level
  • Added new peak info at event level: waveform and area per channel

Extra

  • A new function to see default options per plugin (st.get_config_defaults)
  • More plugins registered in the context (and tested!)

@coveralls
Copy link

coveralls commented Nov 1, 2023

Pull Request Test Coverage Report for Build 7117646782

  • 142 of 183 (77.6%) changed or added relevant lines in 12 files are covered.
  • 59 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.08%) to 39.272%

Changes Missing Coverage Covered Lines Changed/Added Lines %
amstrax/plugins/peaks/peaks.py 2 3 66.67%
amstrax/plugins/events/event_basics.py 1 4 25.0%
amstrax/plugins/events/event_waveform.py 29 36 80.56%
amstrax/plugins/events/event_area_per_channel.py 38 47 80.85%
amstrax/common.py 2 23 8.7%
Files with Coverage Reduction New Missed Lines %
amstrax/plugins/events/event_basics.py 59 51.85%
Totals Coverage Status
Change from base Build 7112062878: -0.08%
Covered Lines: 1025
Relevant Lines: 2610

💛 - Coveralls

@cfuselli cfuselli changed the title It works up to events Peaks and events Dec 6, 2023
@cfuselli cfuselli marked this pull request as ready for review December 6, 2023 13:49
@cfuselli cfuselli merged commit 39ade32 into master Dec 7, 2023
12 checks passed
@cfuselli cfuselli deleted the events branch December 7, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants