Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix data starts earlier than chunk #291

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Fix data starts earlier than chunk #291

merged 2 commits into from
Dec 11, 2023

Conversation

cfuselli
Copy link
Member

We were missing a basic clip on the events start and end time.
We need this to make sure the event does not start earlier than the chunk.

@coveralls
Copy link

coveralls commented Dec 11, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7169491357

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.09%) to 39.235%
Files with Coverage Reduction New Missed Lines %
amstrax/contexts.py 1 76.79%
Totals Coverage Status
Change from base Build 7169453759: 0.09%
Covered Lines: 1026
Relevant Lines: 2615
💛 - Coveralls

@cfuselli cfuselli merged commit d3e6ca1 into master Dec 11, 2023
12 checks passed
@cfuselli cfuselli deleted the fix_events_algo branch December 11, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cfuselli @coveralls