Skip to content

Commit

Permalink
remove my TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
hammannr committed Jul 14, 2023
1 parent 97d3dfe commit 2752b0f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion alea/blueice_extended_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ def _build_ll_from_config(self, likelihood_config: dict) -> "LogLikelihoodSum":
parameters_to_ignore: List[str] = [p.name for p in self.parameters if (p.ptype == "shape")
& (p.name not in source["parameters"])]
# no efficiency affects PDF:
parameters_to_ignore += [ p.name for p in self.parameters if (p.ptype == "efficiency")]
parameters_to_ignore += [p.name for p in self.parameters if (p.ptype == "efficiency")]
parameters_to_ignore += source.get("extra_dont_hash_settings", [])

# ignore all shape parameters known to this model not named specifically in the source:
Expand Down
4 changes: 2 additions & 2 deletions alea/examples/unbinned_wimp_statistical_model.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ likelihood_config:
- signal_efficiency
template_filename: wimp50gev_template.h5
apply_efficiency: True
efficiency_name: signal_efficiency # TODO: Check
efficiency_name: signal_efficiency

# SR1
- name: sr1
Expand Down Expand Up @@ -120,4 +120,4 @@ likelihood_config:
- signal_efficiency
template_filename: wimp50gev_template.h5
apply_efficiency: True
efficiency_name: signal_efficiency # TODO: Check
efficiency_name: signal_efficiency

0 comments on commit 2752b0f

Please sign in to comment.