Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add midway2/3 partition/qos #153

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Add midway2/3 partition/qos #153

wants to merge 11 commits into from

Conversation

shenyangshi
Copy link

A small change that makes the automatic differentiation between midway3 and midway2.

@coveralls
Copy link

coveralls commented Mar 22, 2024

Pull Request Test Coverage Report for Build 8884113640

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.979%

Totals Coverage Status
Change from base Build 8848981890: 0.0%
Covered Lines: 1548
Relevant Lines: 1683

💛 - Coveralls

Copy link
Collaborator

@dachengx dachengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should:

  1. add a condition for midway2 and midway3
  2. warn the user if the hostname is not understandable and assign nothing

alea/submitters/slurm.py Outdated Show resolved Hide resolved
@shenyangshi
Copy link
Author

excluded_nodes as null is added as default for midway3, as without an explicit excluded_nodes, midway3 job submission will yield error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants