Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify SubmitterHTCondor #193

Merged
merged 4 commits into from
Sep 3, 2024
Merged

Simplify SubmitterHTCondor #193

merged 4 commits into from
Sep 3, 2024

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented Sep 2, 2024 •
edited
Loading

Make the class more coherent.

Change wf_id to workflow_id and max_jobs_to_combine to combine_n_outputs for more explicit variable names.

@coveralls
Copy link

coveralls commented Sep 2, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10681663712

Details

  • 1 of 3 (33.33%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 91.374%
Changes Missing Coverage Covered Lines Changed/Added Lines %
alea/utils.py 1 3 33.33%
Files with Coverage Reduction New Missed Lines %
alea/parameters.py 1 90.91%
Totals Coverage Status
Change from base Build 10678802992: -0.2%
Covered Lines: 1663
Relevant Lines: 1820
💛 - Coveralls

@dachengx dachengx marked this pull request as ready for review September 3, 2024 11:03
@dachengx dachengx merged commit 8f99bb8 into main Sep 3, 2024
7 checks passed
@dachengx dachengx deleted the simplify_submitter_htcondor branch September 3, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dachengx @coveralls