Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init code style checking, pytest, and coverage #31

Merged
merged 11 commits into from
Jul 10, 2023
Merged

Init code style checking, pytest, and coverage #31

merged 11 commits into from
Jul 10, 2023

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented Jul 10, 2023

Also, add a bug report template.

The bot still complains about the docstring of functions and classes. The beautifying of the docstring will be in another separate PR. It also complains about assert, we should rethink about whether raise errors instead, but also in another PR.

@@ -0,0 +1,2 @@
def test_gaussian_model():

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pep8] reported by reviewdog 🐶
D103 Missing docstring in public function

@dachengx dachengx marked this pull request as ready for review July 10, 2023 13:12
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

pep8

alea/parameters.py|237 col 1| RST210 Inline strong start-string without end-string.
alea/parameters.py|252 col 16| WPS408 Found duplicate logical condition

alea/statistical_model.py Show resolved Hide resolved
alea/statistical_model.py Show resolved Hide resolved
alea/statistical_model.py Show resolved Hide resolved
alea/statistical_model.py Show resolved Hide resolved
alea/statistical_model.py Show resolved Hide resolved
alea/parameters.py Outdated Show resolved Hide resolved
alea/parameters.py Outdated Show resolved Hide resolved
alea/parameters.py Outdated Show resolved Hide resolved
alea/parameters.py Outdated Show resolved Hide resolved
alea/parameters.py Show resolved Hide resolved
alea/parameters.py Show resolved Hide resolved
alea/parameters.py Show resolved Hide resolved
@dachengx dachengx requested review from hammannr and kdund July 10, 2023 14:03
alea/statistical_model.py Show resolved Hide resolved
alea/statistical_model.py Show resolved Hide resolved
alea/parameters.py Show resolved Hide resolved
alea/parameters.py Show resolved Hide resolved
alea/parameters.py Show resolved Hide resolved
alea/parameters.py Show resolved Hide resolved
Copy link
Collaborator

@kdund kdund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- need to rename appletree to alea, and then good :)?

.github/workflows/pytest.yml Outdated Show resolved Hide resolved
@dachengx dachengx merged commit 94114d3 into master Jul 10, 2023
@dachengx dachengx deleted the code_style branch July 10, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants