-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init code style checking, pytest, and coverage #31
Conversation
@@ -0,0 +1,2 @@ | |||
def test_gaussian_model(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[pep8] reported by reviewdog 🐶
D103 Missing docstring in public function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
pep8
alea/parameters.py|237 col 1| RST210 Inline strong start-string without end-string.
alea/parameters.py|252 col 16| WPS408 Found duplicate logical condition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me -- need to rename appletree to alea, and then good :)?
Also, add a bug report template.
The bot still complains about the docstring of functions and classes. The beautifying of the docstring will be in another separate PR. It also complains about
assert
, we should rethink about whether raise errors instead, but also in another PR.