Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent already cached functions from being changed #125

Merged
merged 4 commits into from
Dec 20, 2023

Conversation

dachengx
Copy link
Collaborator

The users might accidentally change the already cached instances of plugins inside share._cached_functions, by re-deduce and re-compile of components. This PR sets the _cached_functions to be "status": once the value in it is set, it can not be changed.

Copy link

github-actions bot commented Dec 19, 2023

Pull Request Test Coverage Report for Build 7277687843

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 84.073%

Files with Coverage Reduction New Missed Lines %
appletree/component.py 3 78.5%
Totals Coverage Status
Change from base Build 7277560323: -0.1%
Covered Lines: 1969
Relevant Lines: 2342

💛 - Coveralls

@dachengx dachengx marked this pull request as ready for review December 20, 2023 13:10
@dachengx dachengx changed the title Prevent already cached functions to be changed Prevent already cached functions from being changed Dec 20, 2023
@dachengx dachengx added the enhancement New feature or request label Dec 20, 2023
zihaoxu98
zihaoxu98 previously approved these changes Dec 20, 2023
@dachengx dachengx merged commit e9592b5 into master Dec 20, 2023
7 checks passed
@dachengx dachengx deleted the static_cached_functions branch December 20, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants