Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy memory from GPU to CPU #139

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Copy memory from GPU to CPU #139

merged 2 commits into from
Feb 13, 2024

Conversation

dachengx
Copy link
Collaborator

Previously this line

appletree/appletree/component.py

Line 97 in 287ad7c

results[i] = results[i][results[-1] > 0]

was executed only on GPU, so will hit the buffer issue(detail unknown). So for massive simulation, we need to copy the memory onto the CPU.

This is a future fix following #137.

@dachengx dachengx marked this pull request as ready for review February 13, 2024 08:38
@coveralls
Copy link

coveralls commented Feb 13, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7883795742

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 84.007%
Totals Coverage Status
Change from base Build 7883738278: 0.007%
Covered Lines: 1975
Relevant Lines: 2351
💛 - Coveralls

@dachengx dachengx merged commit ec57286 into master Feb 13, 2024
7 checks passed
@dachengx dachengx deleted the jnp_to_np branch February 13, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dachengx @coveralls