Fix a bug of plotter which contains inf #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Pull Request Test Coverage Report for Build 9259389522Details
💛 - Coveralls |
|
Thanks! It is also possible that the posterior is NaN. We should add that check as well and give a warning if it contains inf/NaN. |
for more information, see https://pre-commit.ci
mhliu0001
previously approved these changes
May 27, 2024
dachengx
reviewed
May 27, 2024
appletree/plot.py
Outdated
| self.prior = backend.get_blobs(discard=discard, thin=thin) | ||
| # We drop iterations with inf and nan posterior | ||
| mask = ~np.isinf(self.posterior) & ~np.isnan(self.posterior) |
There was a problem hiding this comment.
dachengx
requested changes
May 27, 2024
dachengx
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the posterior contains inf, which corrupts the xy limit setting of the corner plot. This PR drops the iterations and samples with inf posterior.