Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Modified truncate_normal with jax.random.truncated_normal" #176

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Revert "Modified truncate_normal with jax.random.truncated_normal" #176

merged 1 commit into from
Jul 25, 2024

Conversation

mhliu0001
Copy link
Contributor

Reverts #175. See the new comments in #175. But maybe we can keep the new truncate_normal version, in case someone wants to use that.

@mhliu0001 mhliu0001 requested a review from zihaoxu98 July 25, 2024 12:32
@coveralls
Copy link

coveralls commented Jul 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10094146399

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 84.814%
Totals Coverage Status
Change from base Build 10079888335: 0.1%
Covered Lines: 2368
Relevant Lines: 2792
💛 - Coveralls

@zihaoxu98 zihaoxu98 merged commit b365b2a into master Jul 25, 2024
7 checks passed
@zihaoxu98 zihaoxu98 deleted the revert-175-truncate_normal branch July 25, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zihaoxu98 zihaoxu98 zihaoxu98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhliu0001 @coveralls @zihaoxu98