Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow component lineage with no binning #180

Merged
merged 4 commits into from
Jul 31, 2024
Merged

Allow component lineage with no binning #180

merged 4 commits into from
Jul 31, 2024

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented Jul 31, 2024 •
edited
Loading

When you only simulate datasets, you do not need the binning. So sometimes we do not initialize components with binning.

@dachengx dachengx marked this pull request as ready for review July 31, 2024 09:34
@coveralls
Copy link

coveralls commented Jul 31, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10178750835

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 85.19%
Totals Coverage Status
Change from base Build 10177685760: 0.02%
Covered Lines: 2439
Relevant Lines: 2863
💛 - Coveralls

@dachengx dachengx merged commit f77ae6b into master Jul 31, 2024
6 of 7 checks passed
@dachengx dachengx deleted the tolerate_simulation_only branch July 31, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dachengx @coveralls