Set child_plugin to salting plugins
#48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because they borrowed the functions but not the lineage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because they borrowed the functions but not the lineage.
In other words, if the lineage is sensitive to the change of version of the base class, like
EventShadowSalted, it is fine to not set thechild_pluginto beTrue. But for plugins that only borrow the methods, likeEventBasicsSalted, we need to make sure that the lineage tracks the version change ofEventBasics.To test this, without
child_plugin=True, when__version__ofstraxen.EventBasicsis changed, the linage or hash ofEventBasicsSaltedwill not change.It would be better if we could use XENONnT/straxen#1273 to test this PR. But it is OK because it is not merged.
close #42