Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid including runs without an end from long ago #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cfuselli
Copy link
Member

@cfuselli cfuselli commented Apr 7, 2024

If a run ends badly without an end time in the run database, we do not want to include it in the runs selection.
Here I added a logic that adds that when looking for runs without an end (so, also the current running runs) we make sure that the start time of such run is within the last six hours.

This should fix the problems observed in the plots with runs too old being included.

@cfuselli cfuselli requested a review from mflierm April 7, 2024 09:10
Copy link

@mflierm mflierm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thaaanks a lot! Maybe 3-4 hours would already be sufficient since we rarely take longer runs anyway, but this is a good start so let's see how it goes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants