Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto check binding #56

Merged
merged 7 commits into from
Jun 3, 2024
Merged

Auto check binding #56

merged 7 commits into from
Jun 3, 2024

Conversation

yuema137
Copy link
Contributor

@yuema137 yuema137 commented May 30, 2024

Related to XENONnT/utilix#110 and the idea is basically the same
This PR does the following major changes:

  • Combine several shell scripts written for each server into one, as they are basically the same except for some different settings. So now we only have one core script, which is start_notebook.sh
  • Instead of hard-coded locations, we put all possible locations for images so that the program can search from the list
  • Add an auto-check for the bindings. We only keep usable ones and throw a warning to the users for the invalid ones.
    I have tested the updated functions on midway2, midway3 and dali, and they all work well.

@ghusheng
Copy link

ghusheng commented May 31, 2024

Hi Yue! Than you for the PR! Could you also add --bind /project/lgrandi/xenonnt/dali:/dali to midway3? Otherwise the cutax may be missing. Thanks!

@GiovanniVolta
Copy link

Hey @yuema137, it does not work for me. The variable $PARTITION in start_notebook.sh has no value

@GiovanniVolta GiovanniVolta self-requested a review May 31, 2024 14:19
start_jupyter.py Outdated Show resolved Hide resolved
start_notebook.sh Outdated Show resolved Hide resolved
@yuema137
Copy link
Contributor Author

@GiovanniVolta @ghusheng Thanks for the catches! It's already updated, and it should be good now. Please let me know if there are any missing edge cases

start_notebook.sh Show resolved Hide resolved
@GiovanniVolta
Copy link

As far as I can say it looks good to me

@yuema137 yuema137 requested a review from rsriya June 3, 2024 23:10
@rsriya rsriya merged commit 8ad190a into master Jun 3, 2024
This was referenced Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants