-
Notifications
You must be signed in to change notification settings - Fork 1
Fix classification of alpha events #70
base: master
Are you sure you want to change the base?
Conversation
Hi @cfuselli, thank you for checking the classification method in epix and opening a PR. Right now, epix classifies every interaction with a With your PR the order of the classification checks will be inverted with the result that an interaction with As the core functionality of epix was build we were mostly focusing on NRs from neutrons and the two ER models (beta and gamma)and I think so we did not check in detail how
or
What do you think @ramirezdiego and @WenzDaniel ? |
Hi Henning, I agree this solution is not ideal, it is just a patch. To me it seems like it does the job, but I get the point. I just needed this because the alpha events I am trying to simulate have I think an ideal solution would be your second option, but I am not sure that I have enough ROOT knowledge to implement that. |
This reverts commit 73b11f0.
* Fixed calculation of weighted average time per cluster * BETA quanta generator. * Version update. * Beta-decay clustering. * Brem clustering + refactoring. * Fix. * Fixed common awkwardify function * Updated input arguments, version, and README
Co-authored-by: dachengx <[email protected]>
* Update HISTORY.md * Bump version: 0.3.5 → 0.3.6 * Use trusted publisher
Co-authored-by: Pavel Kavrigin <[email protected]>
* added option to apply total Edep selection, in order to save resources before WFSim * update the function for tot_e calculation * move functions to common.py. Add explanations of new options in README * bug fix * Add escape for empty instructions after the energy selection * add some lines so that to return empty instructions in case no events left after the energy selection * Merge master with cut_by_eventid fix (#81) * Fix cut_by_eventid again * Fix cut_by_eventid again (#80) Co-authored-by: Pavel Kavrigin <[email protected]> --------- Co-authored-by: Pavel Kavrigin <[email protected]> * Polish description in README --------- Co-authored-by: Masatoshi Kobayashi <[email protected]> Co-authored-by: Masatoshi Kobayashi <[email protected]> Co-authored-by: Pavel Kavrigin <[email protected]> Co-authored-by: Pavel Kavrigin <[email protected]> Co-authored-by: Diego Ramírez García <[email protected]>
…to fix_alpha_classification
Alpha events were removed by epix due to interaction misclassification
This pull request aims to fix issue#69.
Due to a problem with how the classify function is defined, all the alpha events are classified as nuclear recoils.
Because of this, when nest is called for alpha events, epix removes all the interactions because the energy is too high for a NR.
Just by inverting the order in which all the options of the classifier are checked, the classify function now correctly classifies alpha events.
Note that:
alpha nestid = 6
NR nestid = 0
As an example, here is what the function returns firstly with the old classifier, and secondly with the new inverted classifier:
The only change is in how the alpha are classified.
Hopefully this does not introduce extra misclassification for other types of events that I did not check.