Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pytest GitHub action #104

Merged
merged 24 commits into from
Jan 31, 2024
Merged

Add pytest GitHub action #104

merged 24 commits into from
Jan 31, 2024

Conversation

dachengx
Copy link
Contributor

@dachengx dachengx commented Jan 17, 2024

  • Add a file to trigger the pytest
  • Add dependencies of straxen and scikit-learn

@dachengx dachengx marked this pull request as draft January 17, 2024 13:16
@dachengx
Copy link
Contributor Author

dachengx commented Jan 17, 2024

The errors are:

ERROR tests/test_FullChain.py - AttributeError: module 'nestpy' has no attribute 'RandomGen'
ERROR tests/test_MicroPhysics.py - AttributeError: module 'nestpy' has no attribute 'RandomGen'
ERROR tests/test_deterministic_seed.py - AttributeError: module 'nestpy' has no attribute 'RandomGen'

which I have reproduced also in the latest montecarlo environment. The errors are from nest_rng = nestpy.RandomGen.rndm(). I do need to ask for help from @ramirezdiego and @HenningSE :)

@dachengx dachengx marked this pull request as ready for review January 17, 2024 13:46
@HenningSE
Copy link
Collaborator

To me this looks like the nestpy version issue.

@ramirezdiego
Copy link
Collaborator

To me this looks like the nestpy version issue.

Yes, I wonder if the nestpy version in the base environment prevents the hardcoded install in the montecarlo_environment.

@dachengx
Copy link
Contributor Author

Yes, I wonder if the nestpy version in the base environment prevents the hardcoded install in the montecarlo_environment.

I think it is not only a problem of base_environment. Maybe I can let GitHub action run XENONnT/montecarlo_environment#8 before testing.

@dachengx
Copy link
Contributor Author

The timeout can only be solved by saving dependencies after #112. As discussed with @HenningSE and @ramirezdiego , I will merge this PR to give more time for other PRs.

@dachengx dachengx merged commit 5cc78d3 into main Jan 31, 2024
0 of 4 checks passed
@dachengx dachengx deleted the action_test branch January 31, 2024 22:12
@dachengx
Copy link
Contributor Author

Sorry, I am wrong about the reason for failed pytests. They are simply because of too short timeout limit. It is fixed by e8f2255.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants