Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ambiance interference simulation with sprinkling method #181

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

mhliu0001
Copy link
Contributor

@mhliu0001 mhliu0001 commented Mar 28, 2024

This PR plans to refactor saltax code by @FaroutYLq and add it to fuse.

This is still a work in progress. Closes #177.

@mhliu0001 mhliu0001 self-assigned this Mar 28, 2024
@coveralls
Copy link

coveralls commented Mar 28, 2024

Pull Request Test Coverage Report for Build 8470647461

Details

  • 48 of 157 (30.57%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.6%) to 66.157%

Changes Missing Coverage Covered Lines Changed/Added Lines %
fuse/plugins/detector_physics/s2_photon_propagation.py 5 6 83.33%
fuse/plugins/pmt_and_daq/pmt_response_and_daq.py 5 6 83.33%
fuse/context.py 2 8 25.0%
fuse/plugins/pmt_and_daq/sprinkled_records.py 34 135 25.19%
Totals Coverage Status
Change from base Build 8358669299: -1.6%
Covered Lines: 1859
Relevant Lines: 2810

💛 - Coveralls

@HenningSE
Copy link
Collaborator

Hi @mhliu0001, do we still need the PR or you want to keep it as an option?

@mhliu0001
Copy link
Contributor Author

Hi Henning, I want to keep it as an extra option in fuse for the moment. I will get back to this PR when I have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ambiance interference
3 participants