Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulse_id type casting inconsistency #260

Merged
merged 2 commits into from
Sep 12, 2024
Merged

pulse_id type casting inconsistency #260

merged 2 commits into from
Sep 12, 2024

Conversation

SaelMo
Copy link
Contributor

@SaelMo SaelMo commented Sep 11, 2024

While checking out why I am getting numpy.exceptions.DTypePromotionError: field titles of field 'pulse_id' mismatch I found this error with Henning and after changing the casting to be consistent it seems to have vanished.

@coveralls
Copy link

coveralls commented Sep 11, 2024

Pull Request Test Coverage Report for Build 10816127142

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.434%

Totals Coverage Status
Change from base Build 10794254376: 0.0%
Covered Lines: 2557
Relevant Lines: 3179

💛 - Coveralls

Copy link
Collaborator

@HenningSE HenningSE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@HenningSE HenningSE merged commit d622926 into main Sep 12, 2024
4 checks passed
@HenningSE HenningSE deleted the pulse_id_dtype_fix branch September 12, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants