Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure CDF goes to 1 smoothly #261

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Make sure CDF goes to 1 smoothly #261

merged 3 commits into from
Sep 12, 2024

Conversation

HenningSE
Copy link
Collaborator

What does the code in this PR do / what does it improve?

This PR makes sure that the CDF for the SPE waveform is properly normalized.

@coveralls
Copy link

coveralls commented Sep 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10829727756

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 50 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 80.434%
Files with Coverage Reduction New Missed Lines %
fuse/plugins/pmt_and_daq/pmt_response_and_daq.py 50 52.38%
Totals Coverage Status
Change from base Build 10826349338: 0.0%
Covered Lines: 2557
Relevant Lines: 3179
💛 - Coveralls

@HenningSE
Copy link
Collaborator Author

A very brief description of the problem is given here.

@HenningSE HenningSE marked this pull request as ready for review September 12, 2024 11:44
ramirezdiego
ramirezdiego approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@ramirezdiego ramirezdiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks a lot.

@HenningSE HenningSE merged commit beb8b43 into main Sep 12, 2024
4 checks passed
@HenningSE HenningSE deleted the spe_cdf_fix branch September 12, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramirezdiego ramirezdiego ramirezdiego approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HenningSE @coveralls @ramirezdiego