Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrections override #269

Merged
merged 5 commits into from
Oct 16, 2024
Merged

Corrections override #269

merged 5 commits into from
Oct 16, 2024

Conversation

HenningSE
Copy link
Collaborator

What does the code in this PR do / what does it improve?

This PR will replace the CorrectedAreas plugin from straxen with a modified one for MC data. It will set cs1 and cs2 to the values of cs1_wo_timecorr and cs2_wo_timecorr as we do not simulate these effects.

@HenningSE HenningSE marked this pull request as ready for review October 11, 2024 10:33
@HenningSE
Copy link
Collaborator Author

Besides the new plugin, this PR removes unused config arguments from the context. This should reduce the number of warnings during the simulation.

@coveralls
Copy link

coveralls commented Oct 11, 2024

Pull Request Test Coverage Report for Build 11364500513

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 19 of 25 (76.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 79.899%

Changes Missing Coverage Covered Lines Changed/Added Lines %
fuse/plugins/processing/corrected_areas.py 8 14 57.14%
Totals Coverage Status
Change from base Build 11364496397: -0.04%
Covered Lines: 2524
Relevant Lines: 3159

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11290679706

Details

  • 19 of 25 (76.0%) changed or added relevant lines in 4 files are covered.
  • 9 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 80.205%

Changes Missing Coverage Covered Lines Changed/Added Lines %
fuse/context.py 7 9 77.78%
fuse/plugins/processing/corrected_areas.py 8 12 66.67%
Files with Coverage Reduction New Missed Lines %
fuse/context.py 9 88.49%
Totals Coverage Status
Change from base Build 11231557079: 0.01%
Covered Lines: 2581
Relevant Lines: 3218

💛 - Coveralls

@GiovanniVolta
Copy link

Hey @HenningSE, thank you very much. It looks good to me. I would just ask you to add in the plugin docstring the motivation for this

Copy link
Collaborator

@ramirezdiego ramirezdiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Henning!

@ramirezdiego ramirezdiego merged commit 205afa5 into main Oct 16, 2024
2 of 4 checks passed
@ramirezdiego ramirezdiego deleted the override_corrections branch October 16, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants