-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrections override #269
Corrections override #269
Conversation
Besides the new plugin, this PR removes unused config arguments from the context. This should reduce the number of warnings during the simulation. |
Pull Request Test Coverage Report for Build 11364500513Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 11290679706Details
💛 - Coveralls |
Hey @HenningSE, thank you very much. It looks good to me. I would just ask you to add in the plugin docstring the motivation for this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, Henning!
What does the code in this PR do / what does it improve?
This PR will replace the
CorrectedAreas
plugin from straxen with a modified one for MC data. It will setcs1
andcs2
to the values ofcs1_wo_timecorr
andcs2_wo_timecorr
as we do not simulate these effects.