Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We increase the default value for the
min_electron_gap_length_for_splitting
. This defines the time windows to split chunks at s2 photon propagation.This was creating issues when afterpulses of large S2s would go out of the chunk boundaries. For some high energy simulations (BiPos with ~5k events/job) this was having a fail rate of ~50% of jobs submitted. With the new configuration the issue now appears less than 1%.
The errors would be of the type:
and it created problems with different plugins, see here out of 393 submittet jobs the plugin that failed:
with the new configuration only 3 runs failed.
Note that this change does not produce lineage change.
Thank you very much to @HenningSE for taking the time to look into this and identify the problem and find a solution :)