Add photoionization plugins #52
Conversation
…to more_afterpulses
|
The last commit changes the calculation of the number of drift surviving electrons from a simple multiplication with the survival probability to the usage of a binomial distribution. This change should better model the number of surviving electrons and should allow the simulation of single electrons! |
|
From the technical perspective the code in this PR is working: |
|
We have to evaluate if the fuse implementation gives results compatible with WFSim since some parts were altered to fit into the fuse framework. When using the context with enabled delayed electrons one has to keep in mind that the simulation will run slower as a lot of single electrons are created! |
HenningSE
changed the title
|
The branch of this PR was quite out of sync with the main branch. Most updates were added without conflicts but some changes need to be done by hand in the next few commits. |
…to more_afterpulses
|
With the last commit, fuse will get the PI settings from the simulation config file. The corresponding PR can be found here: https://github.com/XENONnT/private_nt_aux_files/pull/306. |
|
A comparison between XENONnT data and the PI simulation can be found in the wiki. |
ramirezdiego
changed the title
There was a problem hiding this comment.
Wonderful work, which sets the skeleton many potential upgrades :)
I ran this branch succesfully with and without photoionization and went through the code, finding no issues. We will eventually revisit ramdom_xy_position, as raised by @shenyangshi, but the functionality is already there.
| ) | ||
|
|
||
| # Special case for the photoionization_modifier |
There was a problem hiding this comment.
Why photoionization_modifier is special?
There was a problem hiding this comment.
Hi @dachengx, this part is a little trick to properly set the photoionization_modifier config argument. The problem is that it is not written to the context config by st.apply_xedocs_configs(version=corrections_version) (here). As as result the plugin.run_id would not be overwritten by the corrections_run_id here.
I solved this problem by explicitly writing this config argument to the context config in the set_simulation_config_file function as we loop over all plugins and plugin configs anyways so we will also encounter the photoionization_modifier there. As it is now in the context config, plugin.run_id can now be changed to corrections_run_id.
There was a problem hiding this comment.
Will this be solved if the photoionization_modifier is added to the global config: https://github.com/XENONnT/corrections/blob/92aa12f5fbae460c990e04bc571af0df3f67e68d/XENONnT/global_versions/global_v14.json?
There was a problem hiding this comment.
I think so yes. Then st.apply_xedocs_configs(version=corrections_version) should already take care of this.
This PR will add plugins simulating delayed electrons to fuse. The source of these electrons can be photo ionization.