Sort times by time of first interaction #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ramirezdiego
changed the title
|
Hey @HenningSE, I need anothe reminder here: we now default to this pending the nVeto integration, but the idea was to make an argument out of this option, right? |
|
Hi @ramirezdiego , I guess we would need to treat the NV informations just the same way as we do with the TPC stuff. If we load everything at once we could subtract the same offset and keep everything in sync. Making it optional would also be a good option. |
|
Yes, what I recall from this is that we then need to add the PMT time branches when loading the root file, in order to figure out what comes first. But okay, let's discuss it in #80. |
ramirezdiego
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean Version of #81
This PR changes the the way event and interaction times are set in fuse. With the change in this PR the time of the first interaction in an event is subtracted from the interaction times. As a result we can improve our simulation of isotopes with long lifetimes.