Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move get_window_size factor of merged_s2s as untracked configuration #1209

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented Jun 26, 2023

Before you submit this PR: make sure to put all operations-related information in a wiki-note, a PR should be about code and is publicly accessible

What does the code in this PR do / what does it improve?

The original factor is 5. This PR moves it to an untracked context configuration, because in reprocessing we might want to change it, but better without changing the source code.

It is trying to resolve: AxFoundation/strax#490

This PR will not change the result of MergedS2s. It will not change the lineage either.

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Notes on testing

  • Until the automated tests pass, please mark the PR as a draft.
  • On the XENONnT fork we test with database access, on private forks there is no database access for security considerations.

All italic comments can be removed from this template.

@dachengx dachengx requested a review from WenzDaniel June 26, 2023 05:02
@coveralls
Copy link

Coverage Status

coverage: 93.564% (+0.02%) from 93.541% when pulling 81adf1d on merged_s2s_factor into a952805 on master.

@dachengx dachengx requested a review from FaroutYLq June 26, 2023 10:47
Copy link
Collaborator

@WenzDaniel WenzDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, from a technical point of few it should be fine.

Copy link
Contributor

@FaroutYLq FaroutYLq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me but I would still wait for green light from @WenzDaniel.

@dachengx
Copy link
Collaborator Author

Thanks, both of you!

@dachengx dachengx merged commit be1b81b into master Jun 26, 2023
@dachengx dachengx deleted the merged_s2s_factor branch June 26, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OverlapWindowPlugin causes strax.chunk.CannotSplit
4 participants