-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save first samples of peak(lets) waveform #1406
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also need to add lone_hits to the start of waveform like
strax.add_lone_hits(merged_s2s, lh, self.to_pe, n_top_channels=n_top_pmts_if_digitize_top) |
Thanks @dachengx, yes we should add it! When checking the corresponding code I discovered a bug in strax that we should also fix: AxFoundation/strax#906 |
Needs AxFoundation/strax#908 to merge lone hits into the start of the waveforms |
Thanks @HenningSE ! On top of @dachengx's suggestions, I have a few comments
|
We can not process |
What does the code in this PR do / what does it improve?
This PR uses the code changes in AxFoundation/strax#867 to save the first n_sum_wv_samples of not-downsampled waveforms.