-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put the RunDB API interface and MongoDB interface together #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
yuema137
changed the title
Move the RunDB API interface from utilix to straxen
Put the RunDB API interface and MongoDB interface together
Oct 10, 2024
dachengx
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yuema137 . Please move these later to utilix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As most of XENON packages (XENONnT/utilix#136) are using the DB-related functions implemented in straxen, we propose to remove the redundant module in
utilix
(XENONnT/utilix#138) and keep them withinstraxen
. In general,utilix
should only contain fundamental tools that are widely used whilestraxen
should handle the data management and processing tools which are specifically related to xenonnt data. However, as a historical problem, theAPIUploader
being used byprivate_nt_aux_files
is currently only inutilix
.Therefore, here we migrate the
utilix
code tostraxen,
with improved type hint and docstrings. And we switch to the new implementation here inprivate_nt_aux_file
: https://github.com/XENONnT/private_nt_aux_files/pull/387