Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put the RunDB API interface and MongoDB interface together #1442

Merged
merged 18 commits into from
Oct 10, 2024

Conversation

yuema137
Copy link
Collaborator

@yuema137 yuema137 commented Oct 10, 2024

As most of XENON packages (XENONnT/utilix#136) are using the DB-related functions implemented in straxen, we propose to remove the redundant module in utilix (XENONnT/utilix#138) and keep them within straxen. In general, utilix should only contain fundamental tools that are widely used while straxen should handle the data management and processing tools which are specifically related to xenonnt data. However, as a historical problem, the APIUploader being used by private_nt_aux_files is currently only in utilix.

Therefore, here we migrate the utilix code to straxen, with improved type hint and docstrings. And we switch to the new implementation here in private_nt_aux_file: https://github.com/XENONnT/private_nt_aux_files/pull/387

@yuema137 yuema137 marked this pull request as draft October 10, 2024 19:33
@coveralls
Copy link

coveralls commented Oct 10, 2024

Coverage Status

coverage: 89.849% (-0.5%) from 90.36%
when pulling 6a29dd6 on add_api_inference_db
into 00804e5 on master.

@yuema137 yuema137 marked this pull request as ready for review October 10, 2024 22:23
@yuema137 yuema137 changed the title Move the RunDB API interface from utilix to straxen Put the RunDB API interface and MongoDB interface together Oct 10, 2024
Copy link
Collaborator

@dachengx dachengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yuema137 . Please move these later to utilix.

@dachengx dachengx merged commit f9c689f into master Oct 10, 2024
8 checks passed
@dachengx dachengx deleted the add_api_inference_db branch October 10, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants