Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the whole mongo_storage module to utilix #1445

Merged
merged 19 commits into from
Oct 14, 2024
Merged

Move the whole mongo_storage module to utilix #1445

merged 19 commits into from
Oct 14, 2024

Conversation

yuema137
Copy link
Collaborator

@yuema137 yuema137 marked this pull request as draft October 11, 2024 02:32
@coveralls
Copy link

coveralls commented Oct 11, 2024 •
edited
Loading

Coverage Status

coverage: 90.273% (+0.5%) from 89.758%
when pulling 959b8cc on remove_mongo_storage
into f514d5e on master.

dachengx
dachengx requested changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@dachengx dachengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yuema137 . This is generally good.

docs/source/reference/straxen.storage.rst Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
dachengx
dachengx reviewed Oct 13, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@dachengx dachengx marked this pull request as ready for review October 13, 2024 20:52
@dachengx dachengx merged commit df0d488 into master Oct 14, 2024
7 of 8 checks passed
@dachengx dachengx deleted the remove_mongo_storage branch October 14, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dachengx dachengx dachengx requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuema137 @coveralls @dachengx