Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce codefactor #590

Merged
merged 5 commits into from
Jul 15, 2021
Merged

reduce codefactor #590

merged 5 commits into from
Jul 15, 2021

Conversation

JoranAngevaare
Copy link
Contributor

@JoranAngevaare JoranAngevaare commented Jul 14, 2021

What does the code in this PR do / what does it improve?

Similar to AxFoundation/strax#487, codefactor is really making things a mess. Let's take away it's gunpowder

tests/test_basics.py Show resolved Hide resolved
tests/test_basics.py Show resolved Hide resolved
tests/test_basics.py Show resolved Hide resolved
tests/test_basics.py Show resolved Hide resolved
tests/test_basics.py Show resolved Hide resolved
tests/test_basics.py Show resolved Hide resolved
tests/test_basics.py Show resolved Hide resolved
tests/test_basics.py Show resolved Hide resolved
tests/test_basics.py Show resolved Hide resolved
tests/test_basics.py Show resolved Hide resolved
@ershockley ershockley self-requested a review July 14, 2021 22:36
Copy link
Collaborator

@WenzDaniel WenzDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@WenzDaniel WenzDaniel merged commit 77ab89d into master Jul 15, 2021
@WenzDaniel WenzDaniel deleted the reduce_codefactor branch July 15, 2021 05:05
@JoranAngevaare JoranAngevaare added testing Works on testing code github_actions Pull requests that update Github_actions code labels Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update Github_actions code testing Works on testing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants