Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility issue with alea #89

Merged
merged 7 commits into from
Mar 18, 2024
Merged

Conversation

Microwave-WYB
Copy link
Contributor

Fix compatibility issue with alea by implementing a complete argument list for submit_job.
Also, a .editorconfig is added to enforce CLRF automatically (if supported by the editor).

@yuema137
Copy link
Contributor

I have tested with alea and it works well.
This solves #88 as we add the explicit arguments back to the submit_jobs() to keep consistency
but in the future I think batchq should handle all of the checks, so there is no need to check again in other packages using the submission module. @dachengx how does this sound to you?

@yuema137 yuema137 merged commit 73cafa3 into XENONnT:master Mar 18, 2024
1 check passed
@dachengx
Copy link
Contributor

dachengx commented Mar 19, 2024

Better we(the users like Dacheng & Robert) test before merging next time? : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants