-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add z_bias_map
schema
#100
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dachengx !
Just one thing missing, the fields of the schema :)
Inheriting from TimeIntervalCorrection
will add the version: str
and time: TimeInterval
fields but there is no fields defined to hold the map.
I see now that the maps will be stored in private_nt_aux_files
so i guess this schema will only store the file name for each time period? In that case either add a value: str
field or inherit from the BaseMap
schema which has a value field of type string.
from .base_references import BaseMap
, but BaseMap also has the algorithm
field which may not be relevant.
Another more advanced option would be to add a field called e.g. filename: str
and add a property named value
which loads the file when accessed. I didn't do this for the BaseMap class because i was afraid it may confuse people.
xedocs/schemas/corrections/z_bias.py
Outdated
from .base_corrections import TimeIntervalCorrection | ||
|
||
class ZBias(TimeIntervalCorrection): | ||
_ALIAS = 'z_bias_map' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually we name the collection alias plural, so here it would be z_bias_maps
just so it makes more sense when people try to access the data from xedocs.
If add a property |
For simplicity, maybe just make it similar to what we did for all the other maps. |
Have you had a look at the |
Sorry, I misunderstood your point. I think |
It is a time interval piece-wise correction.
Reference: https://xe1t-wiki.lngs.infn.it/doku.php?id=xenon:xenonnt:terliuk:drift_field_z_bias_correction