Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import mongodownloader from utilix #135

Merged
merged 1 commit into from
Oct 14, 2024
Merged

import mongodownloader from utilix #135

merged 1 commit into from
Oct 14, 2024

Conversation

yuema137
Copy link
Contributor

Keep consistent with: XENONnT/utilix#141

@shenyangshi
Copy link
Contributor

Thanks @yuema137 for the PR. I wasn't closely following the software updates. It seems the essential mongo interface in straxen will also be moved to utilix like in here. Does this we'll treat utilix as dependency for straxen and add it to the base environments?

@dachengx
Copy link
Contributor

utilix is already in base_env: https://github.com/XENONnT/base_environment/blob/36b01dbce38ca0362c52cc2f44c78a129d2ce759/extra_requirements/requirements-tests.txt#L52

dachengx
dachengx requested changes Oct 12, 2024
View reviewed changes
Copy link
Contributor

@dachengx dachengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuema137 Please put utilix in pyproject.toml.

@dachengx dachengx self-requested a review October 14, 2024 20:47
dachengx
dachengx approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@dachengx dachengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we do not need to put utilix in pyproject.toml.

@dachengx dachengx merged commit 6507ad5 into master Oct 14, 2024
4 checks passed
@dachengx dachengx deleted the use_mongodownloader_utilix branch October 14, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dachengx dachengx dachengx approved these changes

@shenyangshi shenyangshi Awaiting requested review from shenyangshi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuema137 @shenyangshi @dachengx