-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hotspot veto #93
hotspot veto #93
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if "corrections" is the correct category for this schema. The corrections are immutable, are we sure this is needed?
Also, take a look at the hotspot report schema under "operations_reports", are you sure this cant be used for cuts?
From my understanding with what Kexin was trying to do it seems like she wanted to have an individual value to be used for a certain number of runs (those with hotspots). I can ask for more details/clarification to see if she does want these values to be immutable and make new version in the future or not. |
@LuisSanchez25 I suggest that you invite the analysts that requested this schema to participate in the discussion here so we have a proper record of the development. |
Hi Luis and Yossi! Thanks for starting this PR : )
|
@chnlkx thanks for the extra details. So if i understand you correctly, this collection will store a threshold number that will be used to cut data that is above this threshold? what config in the cut plugin will this value be used for? |
@jmosbacher Thanks for your comment!
Correct!
I'm trying to use the the URL config in the cut plugin like:
|
@chnlkx in your URL example, you are passing the value of the xedoc document to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks fine.
I think this might be the first a few time dependent cuts people will want to add to xedocs, should we make a separate folder for these cuts since they are not really corrections?