Add photoionization schema #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmosbacher
requested changes
Jul 28, 2023
There was a problem hiding this comment.
Thanks @shenyangshi. This PR needs some cleaning.
- There are changes to all the notebooks in this commit that dont look relevant to the change.
- There are two redundant schemas in two separate files, one of them should be removed.
shenyangshi
force-pushed
the
photoionization
branch
from
c300373
to
ab6c7ff
Compare
|
Thanks @jmosbacher, only realized this we I started the draft PR, now it seems ok. |
jmosbacher
reviewed
Jul 28, 2023
jmosbacher
approved these changes
Jul 28, 2023
|
Hi @jmosbacher, do you think this PR is ready to be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @xzh19980906 will show today the time-dependent corrections can be build using linear correlation with photoionization strength. I propose we store these values too in the corrections, and use this to make all SR1 relative/absolute LY/QY corrections.