[ WIP/ Needs discussion ] handle all binaries with a big constant #539
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #405
Why is this the best possible solution? Were any other approaches considered?
This solution centralizes the handling of Sandbox files in a form while adding support for multiple binary default types.
What are the regression risks?
Users attempting to add sandbox files that don't conform to expectations might see unexpected behavior - I have tried to avoid this but its worth discussing how common it is.
In testing, I found a few CSV and XML handling bugs, but those were cleared up. Still, I dont know if tests are missing for these and other file types being used in an unexpected way.
Overall, my question is: do we have validation on paths to binary files? if not, is now the time to add it? or could we choke out some much needed flexibility?
Does this change require updates to documentation? If so, please file an issue here and include the link below.
Only if we add stricter validation of file types, and even then only maybe.
Before submitting this PR, please make sure you have:
tests_v1
nosetests
and verified all tests passblack pyxform
to format code