Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ WIP/ Needs discussion ] handle all binaries with a big constant #539

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

KeynesYouDigIt
Copy link
Contributor

Closes #405

Why is this the best possible solution? Were any other approaches considered?

This solution centralizes the handling of Sandbox files in a form while adding support for multiple binary default types.

What are the regression risks?

Users attempting to add sandbox files that don't conform to expectations might see unexpected behavior - I have tried to avoid this but its worth discussing how common it is.

In testing, I found a few CSV and XML handling bugs, but those were cleared up. Still, I dont know if tests are missing for these and other file types being used in an unexpected way.

Overall, my question is: do we have validation on paths to binary files? if not, is now the time to add it? or could we choke out some much needed flexibility?

Does this change require updates to documentation? If so, please file an issue here and include the link below.

Only if we add stricter validation of file types, and even then only maybe.

Before submitting this PR, please make sure you have:

  • included test cases for core behavior and edge cases in tests_v1
  • run nosetests and verified all tests pass
  • run black pyxform to format code
  • verified that any code or assets from external sources are properly credited in comments

@KeynesYouDigIt KeynesYouDigIt marked this pull request as draft June 7, 2021 00:21
@KeynesYouDigIt KeynesYouDigIt force-pushed the issue_405_handle_all_binary_defaults_for_supported_sandbox_files branch from 274f273 to e314587 Compare September 11, 2021 22:15
@KeynesYouDigIt KeynesYouDigIt force-pushed the issue_405_handle_all_binary_defaults_for_supported_sandbox_files branch from 20a175f to b6b1ad9 Compare October 9, 2021 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add default value support for image questions
1 participant