Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch Amendment #5060

Open
wants to merge 83 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
83 commits
Select commit Hold shift + click to select a range
879aba5
featureBatch rough draft
dangell7 Jul 10, 2024
46fd68f
clang-format
dangell7 Jul 10, 2024
c57ace7
add atomic swap
dangell7 Jul 17, 2024
91d9909
Merge branch 'develop' into feature-batch
dangell7 Jul 17, 2024
f37377d
add batch `bsig`
dangell7 Jul 17, 2024
b3136a2
[fold] clang-format
dangell7 Jul 17, 2024
5e919eb
[fold] remove `tapRETRY`
dangell7 Jul 27, 2024
1225a61
[fold] remove comments
dangell7 Jul 27, 2024
304ff3e
[fold] fix invariant workaround
dangell7 Jul 27, 2024
aded948
[fold] fix applyTransaction workaround
dangell7 Jul 27, 2024
82d4943
[fold] remove test template
dangell7 Jul 27, 2024
eaf7893
[fold] update logging
dangell7 Jul 27, 2024
ca39807
[fold] remove log
dangell7 Jul 27, 2024
dd71073
clang-format
dangell7 Jul 27, 2024
26518a5
[fold] remove workaround
dangell7 Jul 27, 2024
3ceb05c
update atomic
dangell7 Jul 30, 2024
12324f1
refactor & OpenView `revert()`
dangell7 Jul 31, 2024
e9f045b
[fold] clang-format
dangell7 Jul 31, 2024
51ed234
Merge branch 'develop' into feature-batch
dangell7 Jul 31, 2024
676b9b6
[fold] add revert
dangell7 Jul 31, 2024
6c6180d
[fold] clang-format
dangell7 Jul 31, 2024
bd03ea3
[revert] remove rawRevert func
dangell7 Aug 1, 2024
c0e00b0
refactor with stacking views
dangell7 Aug 3, 2024
a3e15a1
clang-format
dangell7 Aug 3, 2024
14eef60
Merge branch 'develop' into feature-batch
dangell7 Aug 3, 2024
70e9931
[temp] invariant workaround
dangell7 Aug 3, 2024
c693b8f
update fields
dangell7 Aug 3, 2024
418836c
reject batch txn on submit
dangell7 Aug 3, 2024
fe09972
clang-format
dangell7 Aug 3, 2024
a72b070
add tests
dangell7 Aug 3, 2024
0a45c16
[fold] remove unused code
dangell7 Aug 5, 2024
2a0b9d4
include batch execution in tec failures
dangell7 Aug 5, 2024
3a9963a
atomic revert on non tec failures
dangell7 Aug 5, 2024
2c3c5c4
fix sequence & fee
dangell7 Aug 9, 2024
a54a570
Merge branch 'develop' into feature-batch
dangell7 Aug 9, 2024
3ab585b
clang-format
dangell7 Aug 9, 2024
26ee555
previousFields + nested views + signers
dangell7 Sep 5, 2024
0d5242e
clang-format
dangell7 Sep 5, 2024
51990ff
Merge branch 'develop' into feature-batch
dangell7 Sep 5, 2024
ff7fa26
add `sfBatchResult`
dangell7 Sep 5, 2024
ae5abf5
Merge branch 'develop' into feature-batch
dangell7 Sep 10, 2024
a78da6a
ticket sequence
dangell7 Sep 10, 2024
d3a2554
fix metadata
dangell7 Sep 10, 2024
e099e03
fix metadata
dangell7 Sep 10, 2024
84a69ef
fix metadata
dangell7 Sep 10, 2024
f9fe787
update tests
dangell7 Sep 10, 2024
0deea74
clang-format
dangell7 Sep 10, 2024
9266676
remove unused variable
dangell7 Sep 10, 2024
3fff4ca
rename func/field names
dangell7 Sep 10, 2024
ecfc64b
clang-format
dangell7 Sep 10, 2024
096f4bf
[fold] remove log
dangell7 Sep 10, 2024
122368f
Merge branch 'develop' into feature-batch
dangell7 Sep 12, 2024
274660b
add sfTxIDs and update signing
dangell7 Sep 18, 2024
04c5bde
clang-format
dangell7 Sep 18, 2024
e4a5c52
Merge branch 'develop' into feature-batch
dangell7 Sep 18, 2024
659e705
[fixup] rerun actions
dangell7 Sep 18, 2024
597e7fe
[fixup] remove comments
dangell7 Sep 18, 2024
639f8b7
fix no account
dangell7 Sep 22, 2024
75fd76b
clang-format
dangell7 Sep 22, 2024
2925a5d
Merge branch 'develop' into feature-batch
dangell7 Sep 24, 2024
1367e03
Merge branch 'develop' into feature-batch
dangell7 Oct 1, 2024
f185d38
[fold] remove comment
dangell7 Oct 30, 2024
767a88e
[fold] update headers
dangell7 Oct 30, 2024
ee03811
[fold] change error response text
dangell7 Oct 30, 2024
9d8368d
[fold] change flags bit
dangell7 Oct 30, 2024
b408b80
[fold] fix formatting
dangell7 Oct 30, 2024
27d4685
[fold] normal consequences
dangell7 Oct 30, 2024
419b14d
[fold] refactor single/multi sign
dangell7 Oct 30, 2024
6c87e70
[fold] review comments
dangell7 Oct 31, 2024
a75cf0e
[fold] clang-format
dangell7 Oct 31, 2024
e6021bf
[fold] tickets are not chronological
dangell7 Oct 31, 2024
fd0acb7
[fold] fix fee calculation
dangell7 Oct 31, 2024
8a6d6ce
Merge branch 'develop' into feature-batch
dangell7 Oct 31, 2024
dd77e03
[fold] fix merge issues
dangell7 Oct 31, 2024
6cb23e3
[fold] clang-format
dangell7 Oct 31, 2024
88c40e4
[fold] addressing review
dangell7 Nov 6, 2024
e4cb784
[fold] change sequence handling
dangell7 Nov 7, 2024
47120ac
[fixup] rename `prevFields` -> `batchPrevAcctRootFields`
dangell7 Nov 7, 2024
6ed4ac8
[fold] revert applyFlags change
dangell7 Nov 7, 2024
52f1ba9
[fold] use `unordered_set`
dangell7 Nov 7, 2024
1978fd3
Merge branch 'develop' into feature-batch
dangell7 Nov 7, 2024
6ffe349
[fold] clang-format
dangell7 Nov 7, 2024
04519e6
[fold] fix bad merge
dangell7 Nov 7, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libxrpl/protocol/STTx.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ STTx::getSeqProxy() const
std::uint32_t const startSequence{
dangell7 marked this conversation as resolved.
Show resolved Hide resolved
batchTxn.getFieldU32(sfOuterSequence)};
std::uint32_t const batchIndex{batchTxn.getFieldU8(sfBatchIndex)};
return SeqProxy::sequence(startSequence + batchIndex + 1);
return SeqProxy::sequence(startSequence + batchIndex);
dangell7 marked this conversation as resolved.
Show resolved Hide resolved
}

std::optional<std::uint32_t> const ticketSeq{operator[](~sfTicketSequence)};
Expand Down
Loading
Loading