Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: enable TxQ unit tests work with variable reference fee (#5118) #5118

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

vvysokikh1
Copy link
Collaborator

@vvysokikh1 vvysokikh1 commented Sep 6, 2024

High Level Overview of Change

Fix TxQ unit tests to be able to process reference fee value other than 10.

Context of Change

In preparation for potential reference fee change we would like to verify that fee change works as expected. The first step is to fix all unit tests to be able to work with different reference fee values.

Type of Change

  • [x ] Tests (you added tests for code that already exists, or your new feature included in this PR)

API Impact

None

Test Plan

Tested following reference fee values: 10, 20, 50, 100, 200, 500, 1000 by changing https://github.com/vvysokikh1/rippled/blob/2f432e812cb773048530ebfaf2e0e6def51e3cc2/src/test/jtx/impl/envconfig.cpp#L47

@vvysokikh1 vvysokikh1 changed the title test: enable TxQ unit tests work with variable reference fee test: enable TxQ unit tests work with variable reference fee (#5118) Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.2%. Comparing base (1fbf8da) to head (2f14074).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5118     +/-   ##
=========================================
- Coverage     76.2%   76.2%   -0.0%     
=========================================
  Files          760     760             
  Lines        61568   61568             
  Branches      8126    8122      -4     
=========================================
- Hits         46909   46905      -4     
- Misses       14659   14663      +4     

see 3 files with indirect coverage changes

Impacted file tree graph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants