Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce peer message traffic for ledger data #5126

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from

Commits on Sep 11, 2024

  1. Log the caller / reason for server state changes:

    * Also log as warning when the state lowers
    ximinez committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    f0cf1fd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    756cad9 View commit details
    Browse the repository at this point in the history
  3. Drop duplicate outgoing TMGetLedger messages per peer:

    * Allow a retry after 30s in case of peer or network congestion.
    * Addresses RIPD-1870
    * (Changes levelization. That is not desirable, and will need to be
      fixed.)
    ximinez committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    8a17f16 View commit details
    Browse the repository at this point in the history
  4. Drop duplicate incoming TMGetLedger messages per peer:

    * Allow a retry after 15s in case of peer or network congestion.
    * Collate duplicate TMGetLedger requests:
      * The requestCookie is ignored when computing the hash, thus increasing
        the chances of detecting duplicate messages.
      * With duplicate messages, keep track of the different requestCookies
        (or lack of cookie). When work is finally done for a given request,
        send the response to all the peers that are waiting on the request,
        sending a separate message for each requestCookie.
    * Addresses RIPD-1871
    ximinez committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    226cb56 View commit details
    Browse the repository at this point in the history
  5. Drop duplicate incoming TMLedgerData messages:

    * Addresses RIPD-1869
    
    ---------
    
    Co-authored-by: Valentin Balaschenko <[email protected]>
    Co-authored-by: Ed Hennis <[email protected]>
    vlntb and ximinez committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    d5ec2d3 View commit details
    Browse the repository at this point in the history
  6. Collapse multiple outgoing TMLedgerData messages with cookies into one

    * When work is done for a given TMGetLedger request, send the
      response to all the peers that are waiting on the request,
      sending one message per peer, including all the cookies and
      a "directResponse" flag indicating the data is intended for the
      sender, too.
    ximinez committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    ecfa396 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e490e57 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Review feedback from @Bronek:

    * Avoid an unnecessary lookup in CanProcess
    ximinez committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    30eee9b View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Merge remote-tracking branch 'upstream/develop' into pr/getledger

    * upstream/develop:
      Set version to 2.3.0-b4
      feat(SQLite): allow configurable database pragma values (5135)
      refactor: re-order PRAGMA statements (5140)
      fix(book_changes): add "validated" field and reduce RPC latency (5096)
      chore: fix typos in comments (5094)
      Set version to 2.2.3
      Update SQLite3 max_page_count to match current defaults (5114)
    ximinez committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    978fecd View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. [FOLD] Review feedback from @vlntb:

    * Add unit tests for to_short_string(base_uint
    * Remove duplicated code
    * Use type aliases for cookie maps
    ximinez committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    b8b7b31 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. [FOLD] Fix typo in unit test:

    * That's what I get for rushing to push
    ximinez committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    43b6e3e View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Merge remote-tracking branch 'upstream/develop' into pr/getledger

    * upstream/develop:
      Expand Error Message for rpcInternal (4959)
      docs: clean up API-CHANGELOG.md (5064)
    ximinez committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    813ef05 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Merge remote-tracking branch 'upstream/develop' into pr/getledger

    * upstream/develop:
      Consolidate definitions of fields, objects, transactions, and features (5122)
      Ignore reformat when blaming
      Reformat code with clang-format-18
      Update pre-commit hook
      Update clang-format settings
      Update clang-format workflow
    ximinez committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    89f5a67 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Merge remote-tracking branch 'upstream/develop' into pr/getledger

    * upstream/develop:
      Add hubs.xrpkuwait.com to bootstrap (5169)
      docs: Add protobuf dependencies to linux setup instructions (5156)
      fix: reject invalid markers in account_objects RPC calls (5046)
      Update RELEASENOTES.md (5154)
      Introduce MPT support (XLS-33d): (5143)
    ximinez committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    d7e2d70 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. Merge remote-tracking branch 'upstream/develop' into pr/getledger

    * upstream/develop:
      Add AMMClawback Transaction (XLS-0073d) (5142)
    ximinez committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    29de22e View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Merge remote-tracking branch 'upstream/develop' into pr/getledger

    * upstream/develop:
      Fix unity build (5179)
    ximinez committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    e250086 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Merge remote-tracking branch 'upstream/develop' into pr/getledger

    * upstream/develop:
      Set version to 2.3.0-rc1
      Replace Uint192 with Hash192 in server_definitions response (5177)
      Fix potential deadlock (5124)
      Introduce Credentials support (XLS-70d): (5103)
      Fix token comparison in Payment (5172)
      Add fixAMMv1_2 amendment (5176)
    ximinez committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    da4a30c View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. Merge remote-tracking branch 'upstream/develop' into pr/getledger

    * upstream/develop:
      fix: include `index` in `server_definitions` RPC (5190)
      Fix ledger_entry crash on invalid credentials request (5189)
    ximinez committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    eee8184 View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'upstream/develop' into pr/getledger

    * upstream/develop:
      Set version to 2.3.0-rc2
    ximinez committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    85dcf70 View commit details
    Browse the repository at this point in the history