AMM transaction types in account_tx (Clio)
#2337
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tequdev
added
the
needs japanese translation
|
Looks fine, although this should be marked as draft until the Clio 2.1.0 release is officially out |
maria-robobug
added a commit
to maria-robobug/xrpl-dev-portal
that referenced
this pull request
Feb 28, 2024
Now that Clio 2.1.0 has been released, we want to make sure this info is updated in the api methods. Ports changes made in this draft [PR](XRPLF#2337). I will close that draft once this is merged.
|
I created a new PR to cover this change and merged it in: #2426 So I will close this one. |
tequdev
removed
the
needs japanese translation
amarantha-k
pushed a commit
that referenced
this pull request
Mar 5, 2024
Now that Clio 2.1.0 has been released, we want to make sure this info is updated in the api methods. Ports changes made in this draft [PR](#2337). I will close that draft once this is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2335
Feel free to update if this format is not desirable. I was not sure what the most concise way would be.
Basic idea is that we support
AMM*types starting with Clio 2.1.0.