Add Script for SfCode generation #358
Open
+53
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tequdev
suggested changes
Sep 20, 2024
| @@ -198,6 +211,12 @@ | |||
| #define sfHookDefinition ((14U << 16U) + 22U) | |||
| #define sfHookParameter ((14U << 16U) + 23U) | |||
| #define sfHookGrant ((14U << 16U) + 24U) | |||
| #define sfGenesisMint ((14U << 16U) + 96U) | |||
| #define sfActiveValidator ((14U << 16U) + 95U) | |||
| #define sfImport7Key ((14U << 16U) + 94U) | |||
There was a problem hiding this comment.
Suggested change
| #define sfImport7Key ((14U << 16U) + 94U) | |
| #define sfImportVLKey ((14U << 16U) + 94U) |
| #define sfActiveValidators ((15U << 16U) + 95U) | ||
| #define sfImport7Keys ((15U << 16U) + 94U) |
There was a problem hiding this comment.
Suggested change
| #define sfImport7Keys ((15U << 16U) + 94U) | |
| #define sfImportVLKeys ((15U << 16U) + 94U) |
| sed 's/UINT128/4/g' | | ||
| sed 's/UINT256/5/g' | | ||
| sed 's/AMOUNT/6/g' | | ||
| sed 's/VL/7/g' | |
There was a problem hiding this comment.
should fix this not to replace sfImportVLKey, sfImportVLKeys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)