Stage1 MVP Converter Class #266
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 10, 2023 16:41
ziofil
reviewed
Aug 31, 2023
ziofil
reviewed
Aug 31, 2023
ziofil
reviewed
Aug 31, 2023
ziofil
reviewed
Aug 31, 2023
| bargmann_dm = self._wignerdm_to_bargmanndm(wigner_dm=wigner_dm) | ||
|
|
||
| return BargmannKet( | ||
| bargmann_dm.data.A[N:, N:], bargmann_dm.data.b[N:], math.sqrt(bargmann_dm.data.c) |
There was a problem hiding this comment.
wigner ket has no global phase information to preserve here?
There was a problem hiding this comment.
Yes, we miss that information from the wignerdm to bargmanndm and it asked for extra codes to get the global phase part. Are we going to add it?
There was a problem hiding this comment.
if it's not too much work, yes, it would be good to have it
ziofil
reviewed
Aug 31, 2023
ziofil
reviewed
Aug 31, 2023
ziofil
reviewed
Aug 31, 2023
ziofil
reviewed
Aug 31, 2023
Co-authored-by: Filippo Miatto <[email protected]>
Co-authored-by: Filippo Miatto <[email protected]>
Co-authored-by: Filippo Miatto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: Add the converter class to traverse different representation classes for states.
Description of the Change: With the converter, states are able to change its representations.
Benefits: The use of representation is more flexible.
Possible Drawbacks:
Related GitHub Issues: