Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIxes push to dev branch #297

Merged
merged 4 commits into from
Oct 29, 2023
Merged

FIxes push to dev branch #297

merged 4 commits into from
Oct 29, 2023

Conversation

ziofil
Copy link
Collaborator

@ziofil ziofil commented Oct 23, 2023

Context:
I accidentally pushed a few (working) commits to the develop branch

Description of the Change:
Makes the change official and finishes the job

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #297 (4a6b8b0) into develop (34439fc) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #297   +/-   ##
========================================
  Coverage    80.03%   80.03%           
========================================
  Files           57       57           
  Lines         4858     4858           
========================================
  Hits          3888     3888           
  Misses         970      970           
Files Coverage Δ
mrmustard/utils/settings.py 98.27% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34439fc...4a6b8b0. Read the comment docs.

@ziofil ziofil added the no changelog Pull request does not require a CHANGELOG entry label Oct 23, 2023
@SamFerracin
Copy link
Contributor

Thanks for fixing the type hints! :) My bad
Could you also add docs to settings._force_hbar please?

Happy to approve after you reply to my other comment.

As an overall comment, I really dislike the force_hbar mechanism (which I have created, lol) that we use in tests, but I have no better ideas. We may have to think about better solutions for testing settings when we add the new backend. One way may be to test hbar=1 and backend=numpy during the day, and test hbar!=1 (as many values as we want) and backend=tensorflow with nightly workflows

@ziofil ziofil merged commit b5975f6 into develop Oct 29, 2023
6 checks passed
@ziofil ziofil deleted the fix_dev_push branch October 29, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Pull request does not require a CHANGELOG entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants