-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove warnings at the root #307
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #307 +/- ##
========================================
Coverage 82.33% 82.33%
========================================
Files 60 60
Lines 4466 4466
========================================
Hits 3677 3677
Misses 789 789
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @SamFerracin!
I wonder if this PR is also a good opportunity to disable tensorflow's CUDA warning messages — those that appear when importing TF and no GPU is available. What do you think? One option is to just disable them and the other is to install tensorflow-cpu
instead of the full tensorflow
package that includes GPU support. Also, tensorflow-cpu
's wheel is smaller than the full tensorflow
meaning faster setup times.
@sduquemesa That's a great idea. i hate those warnings. Let me look into it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved, up to you to cover casting to int32 correctly
Description of the Change:
Removes
ComplexWarning
at the root (inside the backend) rather than in the functions that require casting