Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warnings at the root #307

Merged
merged 9 commits into from
Nov 27, 2023
Merged

Remove warnings at the root #307

merged 9 commits into from
Nov 27, 2023

Conversation

SamFerracin
Copy link
Contributor

Description of the Change:
Removes ComplexWarning at the root (inside the backend) rather than in the functions that require casting

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #307 (7e9c968) into develop (fba4c72) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #307   +/-   ##
========================================
  Coverage    82.33%   82.33%           
========================================
  Files           60       60           
  Lines         4466     4466           
========================================
  Hits          3677     3677           
  Misses         789      789           
Files Coverage Δ
mrmustard/math/backend_numpy.py 100.00% <ø> (ø)
mrmustard/math/backend_tensorflow.py 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fba4c72...7e9c968. Read the comment docs.

Copy link
Contributor

@sduquemesa sduquemesa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SamFerracin!

I wonder if this PR is also a good opportunity to disable tensorflow's CUDA warning messages — those that appear when importing TF and no GPU is available. What do you think? One option is to just disable them and the other is to install tensorflow-cpu instead of the full tensorflow package that includes GPU support. Also, tensorflow-cpu's wheel is smaller than the full tensorflow meaning faster setup times.

@SamFerracin
Copy link
Contributor Author

@sduquemesa That's a great idea. i hate those warnings. Let me look into it :)

Copy link
Collaborator

@ziofil ziofil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, up to you to cover casting to int32 correctly

@SamFerracin SamFerracin changed the base branch from remove_warnings to develop November 27, 2023 20:33
@SamFerracin SamFerracin merged commit 4aaa320 into develop Nov 27, 2023
7 checks passed
@SamFerracin SamFerracin deleted the remove-warnings-sam branch November 27, 2023 22:58
@ziofil ziofil mentioned this pull request Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants