Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wires final #333

Closed
wants to merge 24 commits into from
Closed

Wires final #333

wants to merge 24 commits into from

Conversation

ziofil
Copy link
Collaborator

@ziofil ziofil commented Jan 30, 2024

sync wires-docs-tests with wires-final before merging it into develop and protytpe-tn

ziofil and others added 22 commits January 28, 2024 14:33
@ziofil
Create wires.py
6d70fec 
Part of MM 1.0 refactor
@ziofil
adds wires tests
544cd74
@ziofil
blacked
1a0eee8
@ziofil
fixed import
cd088c1
@ziofil
moved files
486fcc6
@ziofil
updated changelog
a013d1d
@ziofil
Refactor __bool__ method in Wires class
81d58ad
@ziofil
Fix pointless statements in test cases
362b100
@ziofil
Fix display issue in Wires class
77d7429
@ziofil
Refactor wire connection logic in Wires class
93c58c8
@ziofil
Fix whitespace issue in wires.py
84f7f04
@ziofil
Fix data type in Wires class methods
06226ee
@ziofil
Fix pylint warnings in test_wires.py
466d676
@ziofil
Refactor __rshift__ method in Wires class
4907ec0
@ziofil
simplify errors raised in Wires class
797ebc5
@ziofil
Refactor wire mode merging logic
247a34f
@ziofil
Fix typo in comment
ebb95f5
@ziofil
Fix formatting issues in Wires class
d7c219f
@ziofil
Fix import error in Wires class
a5edc32
@ziofil
blacked
0e9e04c
@ziofil
simplify attempt (for codecov)
eddf339
@ziofil
trick codefactor
a759343
SamFerracin
SamFerracin reviewed Jan 30, 2024
View reviewed changes
Copy link
Contributor

@SamFerracin SamFerracin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of files to remove

mrmustard/lab/wires.py Outdated Show resolved Hide resolved
tests/test_lab/test_wires.py Outdated Show resolved Hide resolved
@ziofil
Copy link
Collaborator Author

ziofil commented Jan 30, 2024

better to merge the other way around

@ziofil ziofil closed this Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamFerracin SamFerracin SamFerracin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ziofil @SamFerracin