Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests and docs for wires final (merge first) #334

Merged
merged 22 commits into from
Feb 1, 2024
Merged

Conversation

SamFerracin
Copy link
Contributor

Description of the Change:
Tests and docs for wires final

@SamFerracin SamFerracin added the no changelog Pull request does not require a CHANGELOG entry label Jan 30, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (ddec322) 84.25% compared to head (e52c1d7) 84.35%.

Additional details and impacted files
@@               Coverage Diff               @@
##           wires-final     #334      +/-   ##
===============================================
+ Coverage        84.25%   84.35%   +0.09%     
===============================================
  Files               65       65              
  Lines             4852     4863      +11     
===============================================
+ Hits              4088     4102      +14     
+ Misses             764      761       -3     
Files Coverage Δ
mrmustard/lab_dev/wires.py 96.77% <85.71%> (+2.96%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddec322...e52c1d7. Read the comment docs.

Copy link
Contributor

@sylviemonet sylviemonet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR!

We need to list the figures that are needed to add as discussed.

mrmustard/lab_dev/wires.py Outdated Show resolved Hide resolved
mrmustard/lab_dev/wires.py Show resolved Hide resolved
SamFerracin and others added 2 commits January 31, 2024 09:29
mrmustard/lab_dev/wires.py Outdated Show resolved Hide resolved
mrmustard/lab_dev/wires.py Outdated Show resolved Hide resolved
mrmustard/lab_dev/wires.py Outdated Show resolved Hide resolved
mrmustard/lab_dev/wires.py Outdated Show resolved Hide resolved
mrmustard/lab_dev/wires.py Outdated Show resolved Hide resolved
mrmustard/lab_dev/wires.py Outdated Show resolved Hide resolved
mrmustard/lab_dev/wires.py Outdated Show resolved Hide resolved
@ziofil ziofil changed the title Tests and docs for wires final Tests and docs for wires final (merge first) Feb 1, 2024
@SamFerracin SamFerracin merged commit fab1991 into wires-final Feb 1, 2024
5 of 6 checks passed
@SamFerracin SamFerracin deleted the wires-final-td branch February 1, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Pull request does not require a CHANGELOG entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants