-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add real_gaussian_integral function #371
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #371 +/- ##
===========================================
- Coverage 87.25% 87.01% -0.24%
===========================================
Files 79 80 +1
Lines 5956 5978 +22
===========================================
+ Hits 5197 5202 +5
- Misses 759 776 +17
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Nice!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great!
Co-authored-by: SamFerracin <[email protected]>
Co-authored-by: SamFerracin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :)
Just make sure that you can see the gaussian integrals in the docs (I can help with that)
Context: Add the code for real_gaussian_integral to help the from_quadrature() function.
Description of the Change: The mathematical formula corresponds to the one on the overleaf Appendix.
TODO list:
Benefits: We can deal with the basis change with a real integral.
Possible Drawbacks: We may need a for loop outside to loop on the integral with different values of b. (Need to be discussed!)
Related GitHub Issues: