Stable Fock conversion #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziofil
commented
Aug 27, 2024
apchytr
reviewed
Aug 29, 2024
apchytr
reviewed
Aug 29, 2024
apchytr
reviewed
Aug 29, 2024
Co-authored-by: Eli Bourassa <[email protected]>
elib20
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a few reworkings of some of our basic numba algorithms:
So far:
[x] 1.8x faster implementation of
vanilla[x] corresponding
vanilla_vjp(only 1.2x faster)[x] 40x faster (🚀!) version of
vanilla_stable[x] 10x faster version of
vanilla_stable_batchedAlso renames the setting from USE_VANILLA_AVERAGE to STABLE_FOCK_CONVERSION (much clearer)