Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TensorFlow v2.17 compatibility by removing optimizer caching #489

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix TensorFlow v2.17 compatibility by removing optimizer caching #489

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions mrmustard/math/backend_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1316,8 +1316,7 @@ def DefaultEuclideanOptimizer(self):
@property
def euclidean_opt(self):
r"""The configured Euclidean optimizer."""
if not self._euclidean_opt:
self._euclidean_opt = self.DefaultEuclideanOptimizer()
self._euclidean_opt = self.DefaultEuclideanOptimizer()
return self._euclidean_opt
Comment on lines 1316 to 1320
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Rename property to method if new instance creation is intended [Best practice, importance: 7]

Suggested change
@property
def euclidean_opt(self):
r"""The configured Euclidean optimizer."""
if not self._euclidean_opt:
self._euclidean_opt = self.DefaultEuclideanOptimizer()
self._euclidean_opt = self.DefaultEuclideanOptimizer()
return self._euclidean_opt
def get_euclidean_opt(self):
r"""Get a new instance of the configured Euclidean optimizer."""
return self.DefaultEuclideanOptimizer()


# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Expand Down
Loading